TreeSelect: Deprecate 36px default size #67855
Conversation
mirka
added
[Type] Code Quality
| @@ -136,7 +136,7 @@ export interface InputBaseProps extends BaseProps, FlexProps { | |||
| * If you want to apply standard padding in accordance with the size variant, wrap the element in | |||
| * the provided `<InputControlPrefixWrapper>` component. | |||
| * | |||
| * @example | |||
| * ```jsx | |||
There was a problem hiding this comment.
Tweaking so the code snippets render correctly in a Markdown file.
| @@ -1,10 +1,10 @@ | |||
| # TreeSelect | |||
|
|
|||
| TreeSelect component is used to generate select input fields. | |||
| <!-- This file is generated automatically and cannot be edited directly. Make edits via TypeScript types and TSDocs. --> | |||
There was a problem hiding this comment.
Taking this opportunity to convert this to an auto-generated README.
| /** | ||
| * A function that receives the value of the new option that is being selected as input. | ||
| */ | ||
| onChange?: SelectControlSingleSelectionProps[ 'onChange' ]; |
There was a problem hiding this comment.
Overriding the prop description here because the original description includes mentions of a multiple prop, which doesn't exist in this component.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in dddaa1f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12303474413
|
| ## Props | ||
|
|
||
| The set of props accepted by the component will be specified below. | ||
| Props not included in this set will be applied to the SelectControl component being used. |
There was a problem hiding this comment.
I think this is useful information that we removed by auto-generating the README. Can we make sure it gets included?
There was a problem hiding this comment.
Mmm right, I think this is something we need to address at the package level. The majority of our components that do pass down props, we don't say that explicitly (e.g. in the canonical Storybook props docs), even though the TS types include them.
Extracted to #67979
There was a problem hiding this comment.
Sounds good to be addressed as a follow-up 👍
Part of #65751
What?
Deprecate the 36px default size on TreeSelect.
Testing Instructions
__next40pxDefaultSizeprop enabled